Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link on pro platform to see nutriscore evolution #11246 #11247

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

stephanegigandet
Copy link
Contributor

fixes #11246

added message when no nutriscore has been computed:

image

added link when we have some nutriscore computed:

image

added taxonomy entries to make the page less cryptic:

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner January 15, 2025 12:54
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Display 🌐 Translations labels Jan 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (662a96b) to head (27ca04a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/ProductOpener/Display.pm 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11247      +/-   ##
==========================================
+ Coverage   40.70%   49.33%   +8.63%     
==========================================
  Files          78       79       +1     
  Lines       22446    22508      +62     
  Branches     5378     5388      +10     
==========================================
+ Hits         9136    11105    +1969     
+ Misses      12140    10042    -2098     
- Partials     1170     1361     +191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jan 17, 2025
@stephanegigandet stephanegigandet enabled auto-merge (squash) January 17, 2025 10:08
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jan 17, 2025
@stephanegigandet stephanegigandet merged commit c0518c1 into main Jan 17, 2025
17 checks passed
@stephanegigandet stephanegigandet deleted the nutriscore-pro2 branch January 17, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Display 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🌐 Translations
Development

Successfully merging this pull request may close these issues.

The facet /misc?filter=nutriscore is not discoverable on the Pro platform
3 participants