fix: Green-Score attributes/panels titles and subtitles #11244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
API
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11244 +/- ##
=======================================
Coverage 49.25% 49.26%
=======================================
Files 78 78
Lines 22418 22417 -1
Branches 5372 5372
=======================================
Hits 11043 11043
+ Misses 10019 10018 -1
Partials 1356 1356 ☔ View full report in Codecov by Sentry. |
alexgarel
approved these changes
Jan 15, 2025
Comment on lines
5391
to
+5393
| msgctxt "attribute_environmental_score_not_applicable_description_short" | ||
| msgid "Not yet applicable for the category" | ||
| msgstr "Not yet applicable for the category" | ||
| msgid "Not applicable for the category" | ||
| msgstr "Not applicable for the category" |
There was a problem hiding this comment.
yes, this just changes the message for some categories like sodas and water. We might get a Green-Score for them at some point, but we don't necessarily want people to think it will come soon.
stephanegigandet
pushed a commit
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [2.55.0](v2.54.0...v2.55.0) (2025-01-17) ### Features * determine packaging components in contact with food ([#11238](#11238)) ([c5cda35](c5cda35)) * serve content without header and footer for mobile app ([#11245](#11245)) ([662a96b](662a96b)) ### Bug Fixes * Green-Score attributes/panels titles and subtitles ([#11244](#11244)) ([1eb84a5](1eb84a5)) * more positive messages for Nova 4 ([#11231](#11231)) ([79e63cd](79e63cd)) * Update fundraiser text to 2025 ([#11248](#11248)) ([b88f43e](b88f43e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes/changes: