Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: building taxonomies for all flavors to catch errors #11217

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

alexgarel
Copy link
Member

We currently only build off taxonomies in CI, this is problematic to catch errors.

@alexgarel alexgarel requested a review from a team as a code owner January 8, 2025 16:52
@github-actions github-actions bot added the GitHub Actions Pull requests that update Github_actions code label Jan 8, 2025
@teolemon teolemon linked an issue Jan 8, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.22%. Comparing base (cdd7cf5) to head (d5b7137).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11217   +/-   ##
=======================================
  Coverage   49.22%   49.22%           
=======================================
  Files          78       78           
  Lines       22405    22405           
  Branches     5374     5374           
=======================================
  Hits        11028    11028           
  Misses      10020    10020           
  Partials     1357     1357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alexgarel
Copy link
Member Author

I don't think it worked because it should have failed (as it does not have this fix)

@alexgarel
Copy link
Member Author

Ok, I should source setenv the file instead !

@alexgarel
Copy link
Member Author

Ok now, we talk ;-)

@alexgarel alexgarel enabled auto-merge (squash) January 9, 2025 14:29
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org labels Jan 9, 2025
Copy link

sonarqubecloud bot commented Jan 9, 2025

@alexgarel alexgarel merged commit a35d15a into main Jan 9, 2025
15 checks passed
@alexgarel alexgarel deleted the ci-test-all-taxonomies branch January 9, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update Github_actions code 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

build taxonomies for opf / obf / opff in CI
4 participants