Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update footer icon and URL #11128

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Update footer icon and URL #11128

wants to merge 5 commits into from

Conversation

areebahmeddd
Copy link
Member

What

Updated the social media icon in the footer to reflect the latest branding changes from Twitter to X. The URL has also been updated to https://x.com/OpenFoodFacts.

Related issue(s) and discussion

@areebahmeddd areebahmeddd requested a review from a team as a code owner December 16, 2024 02:50
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Site layout labels Dec 16, 2024
@areebahmeddd
Copy link
Member Author

  • Didn't add the x.svg file because i was unable to find the appropriate directory for it.
  • Also i think there needs to be lots of url changes because on doing twitter.com search in codebase, lots of file matched the results.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (ac175ce) to head (bf973b2).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11128      +/-   ##
==========================================
+ Coverage   40.64%   49.25%   +8.60%     
==========================================
  Files          77       78       +1     
  Lines       22316    22371      +55     
  Branches     5354     5365      +11     
==========================================
+ Hits         9071    11019    +1948     
+ Misses      12067     9996    -2071     
- Partials     1178     1356     +178

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

/update_tests_results

1 similar comment
@teolemon
Copy link
Member

/update_tests_results

hangy
hangy reviewed Dec 22, 2024
View reviewed changes
templates/web/common/site_layout.tt.html Outdated
<a href="' _ facebook_page_url _ '"><img src="/images/icons/dist/facebook.svg" class="footer_social_icon" alt="Facebook"></a>
<a href="https://www.instagram.com/open.food.facts/"><img src="/images/icons/dist/instagram.svg" class="footer_social_icon" alt="Instagram"></a>
<a href="https://x.com/OpenFoodFacts"><img src="/images/icons/dist/x.svg" class="footer_social_icon" alt="X"></a>
<a href="https://facebook.com/OpenFoodFacts"><img src="/images/icons/dist/facebook.svg" class="footer_social_icon" alt="Facebook"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think '_ facebook_page_url _' and ' _ twitter_account _ ' are placeholders and replaced somehow. Thus, they should probably stay the same in this template.

hangy
hangy reviewed Dec 22, 2024
View reviewed changes
templates/web/common/site_layout.tt.html Outdated
<a href="https://twitter.com/' _ twitter_account _ '"><img src="/images/icons/dist/twitter.svg" class="footer_social_icon" alt="Twitter"></a>
<a href="' _ facebook_page_url _ '"><img src="/images/icons/dist/facebook.svg" class="footer_social_icon" alt="Facebook"></a>
<a href="https://www.instagram.com/open.food.facts/"><img src="/images/icons/dist/instagram.svg" class="footer_social_icon" alt="Instagram"></a>
<a href="https://x.com/OpenFoodFacts"><img src="/images/icons/dist/x.svg" class="footer_social_icon" alt="X"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have x.svg in icons/. It would probably be best to add it in addition to https://github.com/openfoodfacts/openfoodfacts-server/blob/6456ca4775e69431eccf4d658acd07513b33cad0/icons/twitter.svg

@github-actions github-actions bot added the icons label Dec 22, 2024
@areebahmeddd
Copy link
Member Author

Are the above changes satisfactory? @hangy

alexgarel
alexgarel requested changes Jan 2, 2025
View reviewed changes
templates/web/common/site_layout.tt.html Outdated
<a href="' _ facebook_page_url _ '"><img src="/images/icons/dist/facebook.svg" class="footer_social_icon" alt="Facebook"></a>
<a href="https://www.instagram.com/open.food.facts/"><img src="/images/icons/dist/instagram.svg" class="footer_social_icon" alt="Instagram"></a>
<a href="https://instagram.com/open.food.facts"><img src="/images/icons/dist/instagram.svg" class="footer_social_icon" alt="Instagram"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not remove the www as this is the canonical url, please, restore it.

@areebahmeddd
Copy link
Member Author

@alexgarel Restored!

alexgarel
alexgarel approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @areebahmeddd

@alexgarel alexgarel enabled auto-merge (squash) January 6, 2025 09:47
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangy hangy hangy left review comments

@alexgarel alexgarel alexgarel approved these changes

Assignees

@areebahmeddd areebahmeddd

Labels
icons Site layout Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Twitter logo to X
5 participants
@areebahmeddd @codecov-commenter @teolemon @hangy @alexgarel