-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Mozartkugeln #11084
base: main
Are you sure you want to change the base?
taxonomy: Mozartkugeln #11084
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11084 +/- ##
==========================================
+ Coverage 40.64% 49.03% +8.38%
==========================================
Files 77 78 +1
Lines 22316 22374 +58
Branches 5354 5363 +9
==========================================
+ Hits 9071 10971 +1900
+ Misses 12067 10058 -2009
- Partials 1178 1345 +167 ☔ View full report in Codecov by Sentry. |
@@ -41476,6 +41481,11 @@ ciqual_food_code:en: 53503 | |||
ciqual_food_name:en: Yam or Indian potato, peeled, boiled/cooked in water | |||
ciqual_food_name:fr: Igname, épluchée, bouillie/cuite à l'eau | |||
|
|||
< en:Cereals and potatoes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taxonomy wise, Klöse can be potato, meat (Fleischklöße), Quark (Topfenknödel), wheat (Hefeknödel) based, and more. Based on https://de.wikipedia.org/w/index.php?title=Klo%C3%9F&oldid=248171204#Varianten, putting all of them under the potato/cereal parent category sounds a bit inaccurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you are right. Do you think people will would put Fleischklöße under Knödel? I don't speak German well enough to know what would seem logical to german speakers.
We have for example a category "Creams" that refers to "Dairy creams". It is called just "Creams" because it is the common term for it, and people will understand that it refers to dairy creams and that products such as "Cream soups" or "Hazelnut creams" should not go under "Creams".
Do you think people think the Knödel as the potato or bread ones or as any type? If it people would think of any type, how would you call the category for the potato and bread ones? I would create a category for both the bread and cereal/bread ones together since a lot of products contain a mix of cereal and potato (e.g. https://world.openfoodfacts.org/product/4000137005752/semmel-knodel-dr-willi-knoll), similarly to the gnocchi
What
Screenshot
Related issue(s) and discussion