fix: UTM mobile #10665
Merged
fix: UTM mobile #10665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: UTM mobile
github-actions
bot
added
Template::Toolkit
hangy
reviewed
Aug 9, 2024
| @@ -51,6 +51,7 @@ | |||
| <li><a href="[% edq(lang('menu_contribute_link')) %]">[% lang('menu_contribute') %]</a></li> | |||
| <li class="divider"></li> | |||
| <li><label>[% lang("add_products") %]</label></li> | |||
| <!-- For reference: get_the_app_link_off" = /open-food-facts-mobile-app" --> | |||
| <li><a href="[% edq(lang_flavor('get_the_app_link')) %]?utm_source=off&utf_medium=web&utm_campaign=pro_platform_install_the_app_to_add_products_[% language %]">[% lang('install_the_app_to_add_products') %]</a></li> | |||
There was a problem hiding this comment.
Suggested change
| <li><a href="[% edq(lang_flavor('get_the_app_link')) %]?utm_source=off&utf_medium=web&utm_campaign=pro_platform_install_the_app_to_add_products_[% language %]">[% lang('install_the_app_to_add_products') %]</a></li> | |
| <li><a href="[% edq(lang_flavor('get_the_app_link')) %]&utm_source=off&utf_medium=web&utm_campaign=pro_platform_install_the_app_to_add_products_[% language %]">[% lang('install_the_app_to_add_products') %]</a></li> |
There was a problem hiding this comment.
There's no question mark in the root URL, I believe @hangy
There was a problem hiding this comment.
get_the_app_link is in po files @stephanegigandet @hangy
| @@ -242,13 +244,15 @@ | |||
| <!-- full width banner on mobile --> | |||
|
|
|||
| [% IF mobile %] | |||
| <a href="[% mobile.link %]?utm_source=off&utf_medium=web&utm_campaign=mobile-app-top-banner-[% language %]" id="mobile-app-top-banner" class="button large expand success"> | |||
| <!-- For reference: mobile.link = https://play.google.com/store/apps/details?id=org.openfoodfacts.scanner --> | |||
| <a href="[% mobile.link %]&utm_source=off&utf_medium=web&utm_campaign=mobile-app-top-banner-[% language %]" id="mobile-app-top-banner" class="button large expand success"> | |||
There was a problem hiding this comment.
This will fail on an iphone / ipad.
One solution is to add the start of the utm fields to the url in Config_off.pm, so that mobile.link already contains utm=[off|obf...]&utm_medium=web
Same for options.ios_app_link etc.
That way we can just add ?utm_campaign in all cases
stephanegigandet
requested changes
Aug 9, 2024
teolemon
commented
Aug 9, 2024
github-actions
bot
added
🐾 Open Pet Food Facts
github-actions
bot
added
the
🧴 Open Beauty Facts
github-actions
bot
added
the
📸 Open Products Facts
teolemon
commented
Aug 9, 2024
teolemon
commented
Aug 9, 2024
teolemon
commented
Aug 9, 2024
teolemon
commented
Aug 9, 2024
teolemon
commented
Aug 9, 2024
teolemon
commented
Aug 9, 2024
teolemon
commented
Aug 9, 2024
| @@ -328,8 +332,11 @@ <h1 class="if-empty-dnone">[% title %]</h1> | |||
| </div> | |||
| </div> | |||
| <div class="cell small-100 medium-100 large-50 flex-grid v-align-center direction-row"> | |||
| <!-- msgid "https://apps.apple.com/app/open-beauty-facts/id1122926380" --> | |||
| <a class="cell small-50 medium-25 large-25 h-space-short v-align-center" href="[% options.ios_app_link %]?utm_source=off&utf_medium=web&utm_campaign=install_the_app_ios_footer_[% language %]"><img src="[% edq(lang('ios_app_icon_url')) %]" alt="[% edq(lang('ios_app_icon_alt_text')) %]" loading="lazy" class="full-width"></a> | |||
There was a problem hiding this comment.
the utm_source / medium need to be removed for ios too
teolemon
commented
Aug 9, 2024
|
/lint |
|
/update_tests_results |
|
stephanegigandet
pushed a commit
that referenced
this pull request
Aug 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.41.0](v2.40.0...v2.41.0) (2024-08-13) ### Features * generate historical events from product revisions ([#10523](#10523)) ([42508e1](42508e1)) * sync number of product public/pro in CRM ([#10684](#10684)) ([026ff6a](026ff6a)) ### Bug Fixes * 3 fixes to make /products/[code1],[code2] work again ([#10669](#10669)) ([7fc07fc](7fc07fc)) * Automatically unselect images when source image is deleted ([#10692](#10692)) ([588897a](588897a)) * **docs:** correct OpenAPI definition by fixing missing reference ([#10659](#10659)) ([4f0f10e](4f0f10e)) * gen_users_emails.pl ([#10686](#10686)) ([00e4c26](00e4c26)) * Show missing nutrients in Nutri-Score panel ([#10655](#10655)) ([a1b11eb](a1b11eb)) * UTM mobile ([#10665](#10665)) ([965041d](965041d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot
fix: UTM mobile