-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image for issue #26642 unit test #1228
base: 4.x
Are you sure you want to change the base?
Add image for issue #26642 unit test #1228
Conversation
1.11mb is too much for regular tests. Is the issue still relevant, if image is resized 4 times, 2 times or something like this? |
@asmorkalov glad this problem came up, I tried resizing the image, and suddenly the number of detected points dropped dramatically.
|
@JSpencerPittman What if just generate a lot of small horizontal lines in the test code then? |
Found the issue. The image has a lot of introduced static since the background from the images don't easily fit into one of the two bins when applying an adaptive threshold used by the With a new perspective on the problem I'm considering a less invasive PR that simply applies a smoothing filter either in advance or conditionally to remove this static. Horizontal lines alternative for test data.Oh that's convenient, I'll generate the lines from the image and try to use them directly then. I'll also try some resizing without smoothing and maybe cropping to get within the size limit to see if that would work. |
I cropped the region of the image that causes the long hang times while under 1MB. |
The added image will be used in the following PR to solve issue #26642: opencv/opencv#26760.
In the PR I mention why I'm submitting this for a closed issue.