Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared] Bump OTLP proto files to 1.5.0 #6039

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Dec 18, 2024

Handles https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.5.0

Changes

Bump OTLP proto files to 1.5.0

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

// [Optional].
//
// Status: [Development]
string event_name = 12;
Copy link
Contributor Author

@Kielek Kielek Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajkumar-rangaraj, should be add support for this in the OTLP exporter?

now, postopne it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol#environment-variables-1
It'll be bit awkward that EventName gets exported automatically, but EventId still requires opt-in. But still, I think that is the way forward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kielek Not before the next stable release. This was not a part of the earlier code. I see you had created an issue to track this item; we could add it after this stable release.

@Kielek Kielek marked this pull request as ready for review December 18, 2024 09:36
@Kielek Kielek requested a review from a team as a code owner December 18, 2024 09:36
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding EventName can be a separate PR if we chose to add it.

@Kielek
Copy link
Contributor Author

Kielek commented Dec 18, 2024

#6040 - added to Future milestone

@CodeBlanch CodeBlanch changed the title Bump OTLP proto files to 1.5.0 [shared] Bump OTLP proto files to 1.5.0 Dec 18, 2024
@CodeBlanch CodeBlanch merged commit 7d7d37a into open-telemetry:main Dec 18, 2024
49 checks passed
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (2906858) to head (919cadc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6039   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files         257      257           
  Lines       11693    11693           
=======================================
  Hits        10103    10103           
  Misses       1590     1590           

@Kielek Kielek deleted the bump-otlp-1.5.0 branch December 18, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants