-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shared] Bump OTLP proto files to 1.5.0 #6039
Conversation
// [Optional]. | ||
// | ||
// Status: [Development] | ||
string event_name = 12; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajkumar-rangaraj, should be add support for this in the OTLP exporter?
now, postopne it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol#environment-variables-1
It'll be bit awkward that EventName gets exported automatically, but EventId still requires opt-in. But still, I think that is the way forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kielek Not before the next stable release. This was not a part of the earlier code. I see you had created an issue to track this item; we could add it after this stable release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding EventName can be a separate PR if we chose to add it.
#6040 - added to Future milestone |
Handles https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.5.0
Changes
Bump OTLP proto files to 1.5.0
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)