-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scraper component type support to mdatagen #12092
base: main
Are you sure you want to change the base?
Conversation
c2dd39c
to
0eebb74
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
0eebb74
to
1b674b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12092 +/- ##
==========================================
- Coverage 91.60% 91.57% -0.04%
==========================================
Files 456 460 +4
Lines 24091 24574 +483
==========================================
+ Hits 22069 22504 +435
- Misses 1649 1690 +41
- Partials 373 380 +7 ☔ View full report in Codecov by Sentry. |
@@ -325,6 +330,75 @@ func TestComponentLifecycle(t *testing.T) { | |||
} | |||
{{ end }} | |||
|
|||
{{ if isScraper }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not reuse the block above? They are almost identical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 70 lines, and counted that at least 15 are different. Also, we do the same for all other components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will start an effort to remove duplicate code soon across these files.
Updates #11238