Add blocking option to control queue behavior when full #12090
Merged
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
add-blocking-option
branch
from
d87f8db to
cc2374a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12090 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.01%
==========================================
Files 456 456
Lines 24086 24091 +5
==========================================
+ Hits 22064 22067 +3
- Misses 1649 1650 +1
- Partials 373 374 +1 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Jan 15, 2025
Merged
via the queue into
open-telemetry:main
with commit Jan 15, 2025
b9d4e39
56 of 58 checks passed
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 15, 2025
#### Description This test will break `contrib-test` in opentelemetry-collector repo when we add new features in exporter spec. Removing this test as it seems not to be useful(only test string representation) and makes `contrib-test` flaky. Link: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/12786594498/job/35643968597 cc @bogdandrutu #### Link to tracking issue Relevant to open-telemetry/opentelemetry-collector#12090
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5456