Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelcoltest] Add DefaultScheme to test ConfigProvider #12066

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 10, 2025

Description

Adds DefaultScheme to test otelcol.ConfigProvider, so that the test behavior is equivalent to the real thing.

Link to tracking issue

Relates to open-telemetry/opentelemetry-collector-contrib/pull/37122

Testing

Added a test that failed before adding the DefaultScheme.

@mx-psi mx-psi marked this pull request as ready for review January 10, 2025 13:19
@mx-psi mx-psi requested a review from a team as a code owner January 10, 2025 13:19
@mx-psi mx-psi requested review from bogdandrutu and songy23 January 10, 2025 13:19
@mx-psi mx-psi changed the title [otelcoltest] Add DefaultScheme to test ConfigProvider" [otelcoltest] Add DefaultScheme to test ConfigProvider Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (cdea826) to head (6bdaaa6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12066   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         455      455           
  Lines       24010    24011    +1     
=======================================
+ Hits        22010    22011    +1     
  Misses       1629     1629           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@mx-psi mx-psi added this pull request to the merge queue Jan 10, 2025
Merged via the queue into open-telemetry:main with commit 80299d5 Jan 10, 2025
53 checks passed
@mx-psi mx-psi deleted the mx-psi/default-provider branch January 10, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants