[chore] Rename scraper controller to metrics scraper controller #12038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12038 +/- ##
==========================================
- Coverage 91.67% 91.63% -0.05%
==========================================
Files 455 460 +5
Lines 24039 24566 +527
==========================================
+ Hits 22038 22511 +473
- Misses 1629 1667 +38
- Partials 372 388 +16 ☔ View full report in Codecov by Sentry. |
|
Please don't do this. I think you can have a single controller for everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames scraper controller to metrics scraper controller for adding different kinds of scraper controllers
Link to tracking issue
n/a
Testing
n/a
Documentation
n/a