-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confighttp] Add support for configuring compression levels #11805
[confighttp] Add support for configuring compression levels #11805
Conversation
7bbcdeb
to
ad9e1ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11805 +/- ##
=======================================
Coverage 91.60% 91.61%
=======================================
Files 456 456
Lines 24086 24139 +53
=======================================
+ Hits 22064 22114 +50
- Misses 1649 1651 +2
- Partials 373 374 +1 ☔ View full report in Codecov by Sentry. |
853d79f
to
ad9a8a3
Compare
@dmitryax please let me know if there are any other changes that you'd like to see! |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
64722dd
to
ab4e057
Compare
@axw @dmitryax @Aneurysm9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating, LGTM
19ecd8c
to
91d9e72
Compare
…iable names, changelog and tests
7af3d43
to
953d333
Compare
953d333
to
afed63b
Compare
Recommend changing the PR title to emphasize that this is being addressed for HTTP configurations, not gRPC. FYI the OTel-Arrow project also addressed this problem for itself internally on the gRPC path, and I think it would be worth planning for HTTP and gRPC configurations to do the same. Please see https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/internal/otelarrow/compression, which has support for both exporter- and receiver- side configuration of the Zstd compressor. |
a8f95d9
Description
Add the option of configuring compression levels. This is not intended to be a breaking change for the user.
Link to tracking issue
Issue - #10467
Testing
Unit tests were added/changed