Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confighttp] Add support for configuring compression levels #11805

Merged

Conversation

rnishtala-sumo
Copy link
Contributor

Description

Add the option of configuring compression levels. This is not intended to be a breaking change for the user.

Link to tracking issue

Issue - #10467

Testing

Unit tests were added/changed

@rnishtala-sumo rnishtala-sumo force-pushed the compression-config-option2 branch 3 times, most recently from 7bbcdeb to ad9e1ee Compare December 4, 2024 23:22
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.61%. Comparing base (71aae79) to head (683df97).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
config/confighttp/compressor.go 89.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11805   +/-   ##
=======================================
  Coverage   91.60%   91.61%           
=======================================
  Files         456      456           
  Lines       24086    24139   +53     
=======================================
+ Hits        22064    22114   +50     
- Misses       1649     1651    +2     
- Partials      373      374    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.chloggen/compression-config-option2.yaml Outdated Show resolved Hide resolved
.chloggen/compression-config-option2.yaml Outdated Show resolved Hide resolved
config/configcompression/compressiontype.go Show resolved Hide resolved
config/configgrpc/go.mod Outdated Show resolved Hide resolved
config/confighttp/compression.go Outdated Show resolved Hide resolved
config/confighttp/compression_test.go Outdated Show resolved Hide resolved
config/confighttp/compression_test.go Outdated Show resolved Hide resolved
config/confighttp/compression_test.go Outdated Show resolved Hide resolved
config/confighttp/README.md Show resolved Hide resolved
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
@rnishtala-sumo
Copy link
Contributor Author

@dmitryax this latest commit has all the changes from the most recent review.

@rnishtala-sumo
Copy link
Contributor Author

@dmitryax please let me know if there are any other changes that you'd like to see!

Copy link
Contributor

github-actions bot commented Jan 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Jan 3, 2025
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
config/configcompression/compressiontype.go Outdated Show resolved Hide resolved
config/confighttp/compression_test.go Outdated Show resolved Hide resolved
config/confighttp/compressor.go Show resolved Hide resolved
config/confighttp/compressor.go Outdated Show resolved Hide resolved
config/confighttp/compressor.go Outdated Show resolved Hide resolved
config/confighttp/compressor.go Outdated Show resolved Hide resolved
config/confighttp/compressor.go Outdated Show resolved Hide resolved
@rnishtala-sumo
Copy link
Contributor Author

@axw I appreciate the review. If possible, I'd also like @dmitryax or @open-telemetry/collector-approvers to chime in before I implement these changes.

@rnishtala-sumo rnishtala-sumo force-pushed the compression-config-option2 branch 2 times, most recently from 64722dd to ab4e057 Compare January 8, 2025 18:12
config/confighttp/compression_test.go Show resolved Hide resolved
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
@rnishtala-sumo rnishtala-sumo requested a review from axw January 9, 2025 19:37
@rnishtala-sumo
Copy link
Contributor Author

rnishtala-sumo commented Jan 9, 2025

@axw @dmitryax @Aneurysm9
I think I've addressed/resolved most conversations in this PR. Do we think this is close to being ready?

Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating, LGTM

config/configcompression/compressiontype.go Outdated Show resolved Hide resolved
config/configcompression/compressiontype_test.go Outdated Show resolved Hide resolved
@rnishtala-sumo rnishtala-sumo force-pushed the compression-config-option2 branch 3 times, most recently from 19ecd8c to 91d9e72 Compare January 13, 2025 16:36
@rnishtala-sumo rnishtala-sumo force-pushed the compression-config-option2 branch 2 times, most recently from 7af3d43 to 953d333 Compare January 14, 2025 19:05
@rnishtala-sumo rnishtala-sumo force-pushed the compression-config-option2 branch from 953d333 to afed63b Compare January 14, 2025 19:19
@jmacd
Copy link
Contributor

jmacd commented Jan 15, 2025

Recommend changing the PR title to emphasize that this is being addressed for HTTP configurations, not gRPC.

FYI the OTel-Arrow project also addressed this problem for itself internally on the gRPC path, and I think it would be worth planning for HTTP and gRPC configurations to do the same.

Please see https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/internal/otelarrow/compression, which has support for both exporter- and receiver- side configuration of the Zstd compressor.

@dmitryax dmitryax changed the title feat: Add support for configuring compression levels [confighttp] Add support for configuring compression levels Jan 15, 2025
@dmitryax dmitryax added this pull request to the merge queue Jan 15, 2025
Merged via the queue into open-telemetry:main with commit a8f95d9 Jan 15, 2025
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants