-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #17221: Setuptools Version Fix, Resolve Ingestion Setup Failure #17216
Conversation
Phylum OSS Supply Chain Risk Analysis - SUCCESSThe Phylum risk analysis is complete and has passed the active policy. |
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
||
.PHONY: install_apis | ||
install_apis: ## Install the REST APIs module to the current environment | ||
python -m pip install $(ROOT_DIR)/openmetadata-airflow-apis/ setuptools==69.0.2 | ||
PIP_CONSTRAINT=$(ROOT_DIR)/openmetadata-airflow-apis/constraints.txt python -m pip install $(ROOT_DIR)/openmetadata-airflow-apis/ setuptools==69.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we adding these constraints here? Can't we handle it from the setup file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or in pyproject.toml I think we have a requires https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/pyproject.toml#L2
I'd like to avoid having to look at versions to yet another place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried different solutions here, pyproject.toml setuptools version modification didn't work as expected, we already have that in place and it is still failing, the reach for requires doesn't impact 3rd party packages as far as i could test for the setuptools issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding setuptools in depedencies within setup.py didn't work as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only solution that could impact 3rd party packages was the constraint one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one more solution that i have yet to try i.e. --no-build-isolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks, let's keep it as-is until setuptools fixes it on their end
Quality Gate passed for 'open-metadata-airflow-apis'Issues Measures |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Describe your changes:
Fixes #17221 Setuptools Issue
ref: pypa/setuptools#4519
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>