-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create jekyll.yml #948
base: main
Are you sure you want to change the base?
Create jekyll.yml #948
Conversation
✅ Deploy Preview for ols-bebatut ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi. I might miss sth but what is the difference with the existing |
Hi Bérénice - this is me trying out different potential fixes and hoping for the best. :-( |
|
||
- name: Comment with preview URL | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid that will not work for external PR from people who are not added as contributors to the repo. They should not have access to a secret
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to dump a bucket of iced water on my head and come back to this later.
👍🎉 First of all, thanks for taking the time to contribute! 🎉👍
FOR CONTRIBUTOR
PR Type:
FOR REVIEWERS
Thanks for taking the time to review! ❤️
Here are the list of things to make sure of:
{% link path_to_file.md %}
format