Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jekyll.yml #948

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create jekyll.yml #948

wants to merge 2 commits into from

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Jan 16, 2025

👍🎉 First of all, thanks for taking the time to contribute! 🎉👍

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit 6c7d747
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/678900dc92e4970008b592ec
😎 Deploy Preview https://deploy-preview-948--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bebatut
Copy link
Member

bebatut commented Jan 16, 2025

Hi. I might miss sth but what is the difference with the existing deploy.yml workflow?

@NPDebs
Copy link
Collaborator Author

NPDebs commented Jan 16, 2025

Hi. I might miss sth but what is the difference with the existing deploy.yml workflow?

Hi Bérénice - this is me trying out different potential fixes and hoping for the best. :-(


- name: Comment with preview URL
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid that will not work for external PR from people who are not added as contributors to the repo. They should not have access to a secret

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. 😓

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to dump a bucket of iced water on my head and come back to this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants