Parse scope idetifier on IPv6 addresses #1094
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an RFC that describes this change? |
|
Is there a SIP related RFC that describes this change? FWIW, I won’t be able to actually approve or merge this change but changing the grammar without a specification to back up the change would be problematic for interoperability. |
|
Ah probably not. My thought was that when a protocol such as SIP supports IPv6, it should support the whole IPv6 RFC Specs. |
|
For anyone wondering this can happen during call setup to asterisk in local IPv6 mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development we required IPv6 with scope identfiiers in the SIP Via and Contact Header.
New the SIP Via header in the format:
And the SIP Contact header:
can be parsed.
Threre is no additional Field in the NameAddrHeader -> URI. The whole IPv6 address is still stored in the host property.