update create api for v0.5.5 and deprecate create from files #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new create API structure, remove broken file streaming logic - Updates CreateRequest interface with new fields - Removes broken logic for streaming model creation from local files - Previous implementation did not properly handle file streams - Model creation from files should be handled by separate PR - Updates documentation and types to reflect new API structure
ParthSareen
reviewed
Jan 11, 2025
ParthSareen
reviewed
Jan 11, 2025
|
Do we have any issues open for creating tests for the repo? @BruceMacD |
ParthSareen
approved these changes
Jan 11, 2025
Co-authored-by: Parth Sareen <[email protected]>
|
@ParthSareen No tests yet around a lot of stuff, I think we should go the integration tests route so we don't end up with a bunch of mocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new create API structure, remove broken file streaming logic
Updates CreateRequest interface with new fields
Removes broken logic for streaming model creation from local files
Previous implementation did not properly handle file streams
Model creation from files should be handled by separate PR
Updates documentation and types to reflect new API structure
Follow-up: #191