Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #2919

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Create pull_request_template.md #2919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8e96b9
Create pull_request_template.md
matentzn Jun 12, 2023
c8ea3b0
Merge branch 'master' into matentzn-patch-2
cmungall Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
Resolves [#ISSUE]

## General

- [ ] The PR should not contain any spurious changes, i.e. changes that do not relate to the issue linked above

## If the PR involves changes to annotation properties

- [ ] tbd

## If the PR involve changes to the logic (isa, equivalent class)

- [ ] If an equivalent class axiom is added, a "dc:conformsTo" annotation needs to be added linking to the corresponding design pattern
- [ ] If a class is changed that has any indirect children, associated with them (more than two levels of classes underneath),
it must be reviewed by member of core Uberon team

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] #gogoeditdiff is run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will adding this comment trigger the gogoeditdiff?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but not sure if the checkbox will avoid that.


[Add a description, mentioning at least relevant #ISSUE and how it was addressed. A bulleted list of all changes performed by the PR is is helpful.]