Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bath terms #1845

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Add bath terms #1845

merged 2 commits into from
Jan 6, 2025

Conversation

sebastianduesing
Copy link
Contributor

Closes #1585. Adds the following terms:

  • sand bath (OBI:0003688)
  • ice bath (OBI:0003689)
  • dry ice bath (OBI:0003690)
  • liquid nitrogen bath (OBI:0003691)

The diff contains minor changes to src/ontology/modules/devices.owl resulting from a previous edit to the template, which also showed up in #1838.

@sebastianduesing
Copy link
Contributor Author

Discussed on the 2024-12-16 OBI dev call. Ready to merge.

@ddooley
Copy link
Contributor

ddooley commented Jan 3, 2025

Looks good to me. When this is done I can then go in and add a few device terms per issues.

@jamesaoverton jamesaoverton merged commit 3d388d6 into master Jan 6, 2025
1 check passed
@jamesaoverton jamesaoverton deleted the 1585_new_bath_terms branch January 6, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting additional bath terms
3 participants