Auto-generate public/projects.json with working images #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously images imported into vite had hash names; it would be difficult to predict the hash names in a node script to generate projects.json. And annoying to implement it as a vite plugin. Instead, put everything into public/, so file names stay as they are. Issue: no cache busting if we change projects.json or a screenshot without renaming the file. Github pages currently returns cache max-age=600 (10 min).
✅ Deploy Preview for oasisprotocol-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lukaw3d
force-pushed
the
lw/gen-projects-json
branch
from
6b92ff8 to
3b89b9a
Compare
lukaw3d
changed the title
|
Preview: "screenshots": [
"/projects/0x2fa/screenshots/01-landing.jpeg",
"/projects/0x2fa/screenshots/02-balance.jpeg",
"/projects/0x2fa/screenshots/03-activate-2fa.jpeg",
"/projects/0x2fa/screenshots/04-create-multisig.jpeg",
"/projects/0x2fa/screenshots/04-scan-invite-code.jpeg",
"/projects/0x2fa/screenshots/05-banner.png"
], |
|
Slightly related to my WIP #91 , which has this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #90
see diff in 3b89b9a