-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orbit determination constant biases + measurement ambiguity and moduli #398
Conversation
Add serde almost everywhere, focusing on inputs: Outputs, such as event details, should be stored differently, e.g. in a column based storage Add constant offset to noises, add multiplier in TDM parsing/formatting, better check on TDM parsing Add optional moduli on all OD data type and support reading range moduli
…es, must add tests from github ticket. Also greatly expand documentation
Visit the preview URL for this PR (updated for commit 84e4f43): https://nyx-rustdoc--pr398-feat-gh-396-moar-ser-8k6vbtsw.web.app (expires Tue, 21 Jan 2025 21:45:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 67.81% 67.83% +0.01%
==========================================
Files 86 86
Lines 13756 13928 +172
==========================================
+ Hits 9329 9448 +119
- Misses 4427 4480 +53 ☔ View full report in Codecov by Sentry. |
…rde' into feat/gh-396-moar-serde
I don't understand why the od with modulus test fails on GH Actions. I can't get it to fail here: the ground stations are properly configured.
Summary
Architectural Changes
New Features
Improvements
No change
Bug Fixes
Testing and validation
As per #397 :
Simulate a tracking arc with the JPL DSN Code whose modulus is 75660 km. To ensure testing of the ambiguity intervals, fix the
apply_moduli
function to account for that ambiguity. Then, build two tests:Measurements for reference (2x):
So we see that nearly from the start of the arc, we're already at factor of 2x the JPL code. The comforts the properly configured moduli test.
Solving with properly configured moduli
No tuning done at all
The results without any tuning look reasonable, especially in the range component where we've put a full 75 Mm ambiguity from the JPL DSN code.
Solving with a constant bias
No tuning done at all
We see step function residuals and ratios on range around the time the range measurement is > 2x the JPL code ambiguity, causing the filter to rely on Doppler instead.
Documentation
Greatly expanded ODProcess documentation.