Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up Nyx in prep for 2.0.0 #391

Merged
merged 14 commits into from
Jan 1, 2025
Merged

Conversation

ChristopherRabotin
Copy link
Member

Summary

Refer to #390

Architectural Changes

  • Removed Python
  • Remove TrajectoryData and a few IO Python-specific stuff
  • Renamed Mnvr to Maneuver
  • Maneuvers are now specified either by azimuth/elevation or by a vector in the desired frame (previously they were converted into an azimuth/elevation, but that could lead to NaNs)
  • Spacecraft mass, SRP, and Drag now use the ANISE structure

New Features

No change

Improvements

No change

Bug Fixes

No change

Testing and validation

No additional important testing (aside from serde) because this is a cleanup

Documentation

This PR does not primarily deal with documentation changes.

Cargo.toml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 31, 2024

Visit the preview URL for this PR (updated for commit 6eecf3a):

https://nyx-rustdoc--pr391-cleanup-gh-390-4agoj5po.web.app

(expires Wed, 08 Jan 2025 01:10:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d8e2a55934352d850c15d11866c39eb2d2e029be

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 52.47525% with 336 lines in your changes missing coverage. Please review.

Project coverage is 67.81%. Comparing base (cc00ae3) to head (6eecf3a).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
src/dynamics/guidance/mnvr.rs 13.82% 81 Missing ⚠️
src/od/msr/trackingdata/io_ccsds_tdm.rs 32.17% 78 Missing ⚠️
src/md/opti/raphson_finite_diff.rs 9.09% 50 Missing ⚠️
src/md/trajectory/sc_traj.rs 77.93% 32 Missing ⚠️
src/dynamics/drag.rs 0.00% 28 Missing ⚠️
src/md/opti/solution.rs 4.54% 21 Missing ⚠️
src/cosmic/spacecraft.rs 72.97% 20 Missing ⚠️
src/polyfit/polynomial.rs 91.66% 8 Missing ⚠️
src/od/msr/types.rs 0.00% 7 Missing ⚠️
src/od/msr/sensitivity.rs 0.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   66.92%   67.81%   +0.89%     
==========================================
  Files          89       86       -3     
  Lines       13679    13756      +77     
==========================================
+ Hits         9154     9329     +175     
+ Misses       4525     4427      -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cargo.toml Outdated Show resolved Hide resolved
@ChristopherRabotin ChristopherRabotin merged commit 0dede89 into master Jan 1, 2025
7 checks passed
@ChristopherRabotin ChristopherRabotin deleted the cleanup/gh-390 branch January 1, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant