Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite and fixes Ueberzug. #37

Closed
wants to merge 48 commits into from
Closed

Conversation

dharmx
Copy link

@dharmx dharmx commented Jan 6, 2023

Title.

Combines #18.

@dharmx dharmx force-pushed the main branch 4 times, most recently from 1cb8dc2 to c3da7a1 Compare January 7, 2023 20:31
@Conni2461
Copy link
Member

Note that there is also #35

which replaces the backend. I am currently not sure if i want to continue to use ueberzug (or even have it as backend available) because the author took it down and we could/should respect their decision

@dharmx dharmx force-pushed the main branch 2 times, most recently from a981d5c to 775ce6b Compare January 8, 2023 15:01
@dharmx
Copy link
Author

dharmx commented Jan 9, 2023

Note that there is also #35

which replaces the backend. I am currently not sure if i want to continue to use ueberzug (or even have it as backend available) because the author took it down and we could/should respect their decision

I did see that. But, I kind of dislike using bash or, any other shell script for communicating to ueberzug or, whatever for that matter. So, the initial idea was to rewrite everything in Lua and using async jobs and what not. As, a consequence I figured out why ueberzug processes weren't killed by new_termopen_viewer #28 (which this project uses - which uses jobstart) and solved it by accident.

Also, there has been an update to the ueberzug situation (which I think is interesting). And, personally telescope-media-files.nvim is a really nice plugin which has been tightly integrated to my workflow. It is completely okay if this does not get merged. Frankly, I think my fork branches off from what this plugin was aiming to be originally (which is a image viewer).

Also I should say that this supports multiple backends here. And I am planning to add more if I find any.

Sorry, for the late reply.

@dharmx dharmx force-pushed the main branch 2 times, most recently from 50a52d4 to 289041d Compare May 8, 2023 12:14
@dharmx dharmx force-pushed the main branch 2 times, most recently from c51bf0a to 343e71c Compare May 11, 2023 08:15
@dharmx dharmx force-pushed the main branch 2 times, most recently from 2ec952b to d7bb3e0 Compare June 25, 2023 10:22
@eylles
Copy link

eylles commented Jul 19, 2023

I am currently not sure if i want to continue to use ueberzug (or even have it as backend available) because the author took it down and we could/should respect their decision

i'd say that ship already sailed as ueberzug is being maintained and packaged.

@dharmx
Copy link
Author

dharmx commented Jul 20, 2023

Closing this as my fork took a completely different direction. I was not aware that my commits were polluting this LOL.

@dharmx dharmx closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants