-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiprocess Stage POC #1170
Open
cwharris
wants to merge
12
commits into
nv-morpheus:branch-23.11
Choose a base branch
from
cwharris:py-multi-proc
base: branch-23.11
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multiprocess Stage POC #1170
+248
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwharris
added
non-breaking
Non-breaking change
feature request
New feature or request
labels
Sep 4, 2023
Hey @cwharris should we promote this out of draft since you're requested review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example demonstrates the use of Python Multiprocessing with a custom Stage, which enables offloading of MultiMessage processing to a separate process while continuing the workflow within the same process.
The example results in a segfault originating from
Watchable::watcher_epilogue
when callingsub.on_next
from python in the parent process. It appears that one ofm_watchers
has been released and we're still trying to access it. Unfortunately I don't know enough about MRC to say what the cause is.I was able to work around the issue by simply commenting out the
obs->on_exit(...)
call and rebuilding MRC and Morpheus together. Everything seemed to work fine, so maybe this is a bug in MRC?Checklist