-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tester class #814
Remove tester class #814
Conversation
By analyzing the blame information on this pull request, we identified @scottpurdy, @utensil and @david-ragazzi to be potential reviewers |
2031979
to
0cb8db5
Compare
…hat is required for PathTest::copyInTemp to run successfully.
0cb8db5
to
b6bc980
Compare
I think you can remove |
@scottpurdy Do you have a reference for not including a main() function and therefore being able to delete |
@SaganBolliger - Does this help? http://stackoverflow.com/a/21479008 |
@scottpurdy As we discussed, the current installation of gtest does not include gtest_main. I've opened #815, which describes this. |
I'd say delete the test headers rather than leaving them commented out. The source files are fine to leave commented though. |
Done reviewing. |
This PR concludes the porting off all nupic.core tests to gtest, and so it fixes #208.
@scottpurdy