Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tester class #814

Merged
merged 5 commits into from
Jan 6, 2016

Conversation

SaganBolliger
Copy link
Contributor

  • Deleted Tester class and TesterTest unit tests.
  • Modified CMakeLists to remove the old Tester build instructions.
  • Commented out dependencies on Tester in already commented out math tests (see Unittests missing for critical code in math/*Matrix*  #376)
  • Moved initialization previously done in Tester::init into PathTest::PathTest for unit test that depends on that initialization (it was the only unit test that depended on that initialization).
  • Removed references to Tester from UnitTestMain.cpp test runner script

This PR concludes the porting off all nupic.core tests to gtest, and so it fixes #208.

@scottpurdy

@numenta-ci
Copy link

By analyzing the blame information on this pull request, we identified @scottpurdy, @utensil and @david-ragazzi to be potential reviewers

@SaganBolliger SaganBolliger force-pushed the 208-remove-tester-class branch from 2031979 to 0cb8db5 Compare January 6, 2016 00:44
@SaganBolliger SaganBolliger force-pushed the 208-remove-tester-class branch from 0cb8db5 to b6bc980 Compare January 6, 2016 00:48
@scottpurdy
Copy link
Contributor

I think you can remove src/test/unit/UnitTestMain.cpp and simply link against the gtest_main library that comes with googletest.

@SaganBolliger
Copy link
Contributor Author

@scottpurdy Do you have a reference for not including a main() function and therefore being able to delete UnitTestMain.cpp?

@scottpurdy
Copy link
Contributor

@SaganBolliger - Does this help? http://stackoverflow.com/a/21479008

@SaganBolliger
Copy link
Contributor Author

@scottpurdy As we discussed, the current installation of gtest does not include gtest_main. I've opened #815, which describes this.

@scottpurdy
Copy link
Contributor

I'd say delete the test headers rather than leaving them commented out. The source files are fine to leave commented though.

@scottpurdy
Copy link
Contributor

Done reviewing.

scottpurdy added a commit that referenced this pull request Jan 6, 2016
@scottpurdy scottpurdy merged commit 621a1b7 into numenta:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Tester class from unit test framework
3 participants