Sp cleanup #1037
Closed
Sp cleanup #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it avoids unnecessary conversions + is faster than the dense/binary version
add threshold to determine what is considered "valid" (e.g. >0, >=1,..) Used in SP
replaces with VectorHelpers.binaryToSparse()
|
By analyzing the blame information on this pull request, we identified @scottpurdy, @subutai and @baroobob to be potential reviewers |
In the last discussion we had about this, @scottpurdy disagreed with adding the vector helper code and listed his reasons here. Unless he has changed his mind on that, I don't see how this PR is going to get merged. |
|
WARNING! This Pull Request has been inactive for 25 days, and will be automatically closed in 5 days if not updated before then. This is an automated message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
VectorHelpersfrom low level anomaly detection example #890 (we already had a discussion about that in Vector utils #903 , but it is to be used now in AD-example, shows its usega as simplification of SP in this PR,...)Blocked by #1036
Fixes #1035