Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests missing for critical code in math/*Matrix* #376

Open
7 tasks
breznak opened this issue Feb 28, 2015 · 3 comments
Open
7 tasks

Unittests missing for critical code in math/*Matrix* #376

breznak opened this issue Feb 28, 2015 · 3 comments

Comments

@breznak
Copy link
Member

breznak commented Feb 28, 2015

There's a lot of tests in https://github.com/numenta/nupic.core/tree/master/src/test/unit/math
that are actually fake and the code is commented out! As this should be critical code, we need the tests back and running.

Here is a list of math test files containing entirely commented out code:


@rhyolight rhyolight added this to the 0.7.0 milestone Feb 28, 2015
@rhyolight rhyolight modified the milestones: 0.7.0: Bug bash, 1.0.0 Mar 30, 2015
@SaganBolliger
Copy link
Contributor

Here is a list of math test files containing entirely commented out code:
DenseTensorUnitTest
DomainUnitTest
IndexUnitTest
MathsTest
SparseMatrix01UnitTest
SparseMatrixUnitTest
SparseTensorUnitTest

@rhyolight
Copy link
Member

Please review this issue

This issue needs to be reviewed by the original author or another contributor for applicability to the current codebase. The issue might be obsolete or need updating to match current standards and practices. If the issue is out of date, please close. Otherwise please leave a comment to justify its continuing existence. It may be closed in the future if no further activity is noted.

@breznak
Copy link
Member Author

breznak commented May 18, 2016

confirmed, tests are still commented out

breznak added a commit to breznak/nupic.core that referenced this issue Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants