Write mutations to: create a community and join a community #41

noghartt · 2021-12-15T03:34:24Z

Description

With this PR, we are adding these mutations: communityCreate and communityJoin that will be responsible to create and join communities based on communityId.

`communityCreate`

To run this mutation, you just run it:

mutation communityCreate($displayName: String!, $communityId: String!) {
  communityCreate(
    input: { displayName: $displayName, communityId: $communityId }
  ) {
    community {
      id
      name
      displayName
      members
    }
  }
}

`communityJoin`

To run this mutation, you just run it:

mutation communityJoin($communityId: String!) {
  communityJoin(input: { communityId: $communityId }) {
    community {
      id
      members
    }
    me {
      id
      communities
    }
  }
}

Observations

The tests for these mutations were added too;
We bump the version of koa-graphql to ^v0.12.0;
We change the dependency from koa-router to @koa/router (is the same package);
We add user object to context from each request;
- Maybe it can be refactored in the future to validate if the user is logged in on a middleware.

daniloab · 2021-12-15T12:20:09Z

packages/server/src/auth.ts

+): Promise<Maybe<UserDocument>> => {
+  if (!token) return null;
+
+  // TODO: Maybe it should be a crime


Drastic measures are sometimes necessary lmao

packages/server/src/modules/community/mutations/createCommunityMutation.ts

daniloab · 2021-12-15T12:22:54Z

packages/server/src/modules/community/mutations/createCommunityMutation.ts

+    ctx: GraphQLContext,
+  ) => {
+    // TODO: In some way, you can pass it to a middleware. But IDK how to do it yet.
+    if (!ctx.user) {


https://github.com/daniloab/rbaf-graphql-api/blob/master/src/server/app.ts#L18

packages/server/src/modules/community/mutations/createCommunityMutation.ts

packages/server/src/modules/community/mutations/index.ts

packages/server/src/modules/community/CommunityModel.ts

daniloab · 2021-12-15T12:30:09Z

packages/server/src/modules/community/mutations/joinCommunityMutation.ts

+      resolve: async ({ communityId }) =>
+        await CommunityModel.findOne({ _id: communityId }),
+    },
+    me: {


create the auth auth middleware based on this https://github.com/daniloab/rbaf-graphql-api/blob/master/src/server/app.ts#L18

then, expose me to the query type, and should be enough. This will help you to avoid declaring me on mutation output fields.

I don't understand exactly what you suggest here, how can I do it?

daniloab · 2021-12-15T12:30:32Z

packages/server/src/modules/community/mutations/joinCommunityMutation.ts

+    const community = await CommunityModel.findOne({ name: communityId });
+
+    if (!community) {
+      throw new Error("This community doesn't exist. Please, try again.");


maybe you can return errors on graphql output mutation

I was thinking about it, but for now, I intend to keep throw because I can more objectively handle the error on the front-end.

But I guess that it's one of the ways that I think to implement error handling on the "server-side". I'm just waiting to answer my question here to decide how I deal with errors.

daniloab · 2021-12-15T12:31:20Z

packages/server/src/modules/community/mutations/joinCommunityMutation.ts

+      community.updateOne({
+        $addToSet: { members: [...community.members, ctx.user._id] },
+      }),
+      ctx.user.updateOne({


prefer to get the user itself from MongoDB and then update it.

implement dataloaders to help you with this.

daniloab · 2021-12-15T12:31:47Z

packages/server/src/modules/user/UserModel.ts

 }

-interface UserDocument extends User, Document {
+export interface UserDocument extends User, Document {


IUser could be cool

IMO the I prefix on interfaces is unnecessary because in all modern editors (and IDEs) you can know that UserDocument is an interface, I think that this prefix isn't necessary.

daniloab

awesome pr

packages/server/src/modules/community/mutations/index.ts

daniloab

merge this and send the changes into small prs

noghartt · 2021-12-16T16:00:02Z

merge this and send the changes into small prs

Sure! I'll create issues with the rest of the changes!

noghartt added 18 commits December 14, 2021 22:59

build(deps): update version of koa-graphql dependency

fab0fa7

feat: add headerEditorEnabled on graphiql option on koa-graphql

796eddd

feat: write a auth function to get user if exists

7c52e92

feat: add user to context on graphql request

d49a8d6

feat: add communities array as field on the user document

b4c70bd

feat: write CommunityModel

9aae6dd

feat: write CommunityType

cbe405b

feat: write createCommunityMutation

1ab48e2

feat: write joinCommunityMutation

26e0ffd

test: write a method to upsert models on tests

fce6b07

style: improve types on createUser fixture function

b2ecbaf

test: write a fixture to create communities

38fb0fb

test: write tests to createCommunityMutation

7dd3290

test: write tests to joinCommunity.test.ts

8a2fe45

build(tsconfig): exclude test files and fixtures when build server

ccb831f

chore(gitignore): fix /graphql folder on gitignore

9c530da

style: add setting to detect react version on eslint config

033f29a

feat: write graphql modules with initial GraphQLContext type

7fe1e33

noghartt force-pushed the server/create-community branch from dc7efde to 4d49262 Compare December 15, 2021 12:18

daniloab reviewed Dec 15, 2021

View reviewed changes

packages/server/src/modules/community/mutations/createCommunityMutation.ts Outdated Show resolved Hide resolved

daniloab reviewed Dec 15, 2021

View reviewed changes

packages/server/src/modules/community/mutations/createCommunityMutation.ts Outdated Show resolved Hide resolved

daniloab reviewed Dec 15, 2021

View reviewed changes

packages/server/src/modules/community/mutations/createCommunityMutation.ts Outdated Show resolved Hide resolved

daniloab reviewed Dec 15, 2021

View reviewed changes

packages/server/src/modules/community/mutations/createCommunityMutation.ts Outdated Show resolved Hide resolved

daniloab reviewed Dec 15, 2021

View reviewed changes

packages/server/src/modules/community/mutations/index.ts Outdated Show resolved Hide resolved

daniloab reviewed Dec 15, 2021

View reviewed changes

packages/server/src/modules/community/CommunityModel.ts Show resolved Hide resolved

daniloab reviewed Dec 15, 2021

View reviewed changes

daniloab approved these changes Dec 15, 2021

View reviewed changes

noghartt added 4 commits December 15, 2021 10:40

style: rename community mutations to avoid redundancy

97f6002

fix(community): instantiates a new model with correctly properties

671a6bf

style: move outputFields on community mutations down from resolvers

0468961

style: change findedCommunity to communityFound

49c02f5

noghartt force-pushed the server/create-community branch from 4d49262 to 49c02f5 Compare December 15, 2021 13:43

daniloab reviewed Dec 15, 2021

View reviewed changes

packages/server/src/modules/community/mutations/index.ts Show resolved Hide resolved

noghartt added 2 commits December 15, 2021 11:02

test: rename community mutation tests to according with mutations

6370492

feat: add ref prop to fields on Community schema

c746bcf

daniloab approved these changes Dec 16, 2021

View reviewed changes

This was referenced Dec 16, 2021

Implements Dataloaders #43

Closed

Write a middleware to validate if user has authorization #44

Closed

Based on auth middleware, fix the output of communityJoin mutation #45

Closed

noghartt merged commit d77482a into main Dec 16, 2021

noghartt deleted the server/create-community branch December 16, 2021 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Write mutations to: create a community and join a community #41

Write mutations to: create a community and join a community #41

noghartt commented Dec 15, 2021 •

edited

Loading

daniloab Dec 15, 2021

noghartt Dec 15, 2021

daniloab Dec 15, 2021

daniloab Dec 15, 2021

noghartt Dec 16, 2021

daniloab Dec 15, 2021

noghartt Dec 15, 2021

daniloab Dec 15, 2021

daniloab Dec 15, 2021

noghartt Dec 15, 2021

daniloab Dec 15, 2021

daniloab left a comment

daniloab left a comment •

edited

Loading

noghartt commented Dec 16, 2021

Write mutations to: create a community and join a community #41

Write mutations to: create a community and join a community #41

Conversation

noghartt commented Dec 15, 2021 • edited Loading

Description

communityCreate

communityJoin

Observations

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniloab left a comment

Choose a reason for hiding this comment

daniloab left a comment • edited Loading

Choose a reason for hiding this comment

noghartt commented Dec 16, 2021

noghartt commented Dec 15, 2021 •

edited

Loading

`communityCreate`

`communityJoin`

daniloab left a comment •

edited

Loading