test_runner: remove unused errors #56607
Open
+19
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
|
@cc @nodejs/test_runner |
pmarchini
added
the
test_runner
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56607 +/- ##
==========================================
+ Coverage 89.12% 89.20% +0.07%
==========================================
Files 662 662
Lines 191555 191801 +246
Branches 36859 36920 +61
==========================================
+ Hits 170722 171092 +370
+ Misses 13694 13563 -131
- Partials 7139 7146 +7
|
cjihrig
approved these changes
Jan 15, 2025
| @@ -2821,25 +2821,6 @@ An unspecified or non-specific system error has occurred within the Node.js | |||
| process. The error object will have an `err.info` object property with | |||
| additional details. | |||
|
|
|||
| <a id="ERR_TAP_LEXER_ERROR"></a> | |||
There was a problem hiding this comment.
There is a section on this page for legacy errors that are no longer used. I think these should be moved there?
There was a problem hiding this comment.
Moved them under the correct section!
pmarchini
force-pushed
the
test_runner/remove-unsued-tap-errors
branch
from
d207e7e to
a817ea6
Compare
JakobJingleheimer
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
ERR_TAP_PARSER_ERROR,ERR_TAP_LEXER_ERRORandERR_TAP_VALIDATION_ERRORare no longer used in the codebase.Does it make sense to perform some housekeeping by removing them?