-
Notifications
You must be signed in to change notification settings - Fork 71.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fix WS v1 #8111
WIP: fix WS v1 #8111
Conversation
Looks ok. For contrast, here's how Sulka updated similar areas, it reads a little differently but I think winds up being functionally equivalent. https://github.com/nightscout/cgm-remote-monitor/blob/master/lib/server/devicestatus.js#L26-L58 |
Looks like we might have a check list of sorts:
|
Should we roll back #8026 or continue to make changes? |
@bewest it's up to you. this patch is working and ready. But we must resolve all other places .... |
if rollback makes no conflicts maybe I'd prefer it as a fast solution |
calling |
No description provided.