Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate from yarn to pnpm, remove CircleCI config #4670

Merged
merged 21 commits into from
Jan 15, 2025
Merged

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Jan 11, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • yarn 1.x is removed in favor of pnpm for dependency installation and running commands. The docs-app still uses yarn but will be replaced with the new docs site.
  • The CircleCI configuration is removed. GitHub Actions were introduced to run our CI/CD.
  • Updates to Nx 20.3.0

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 968adbb
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6782d59ed56e310008ccea1c
😎 Deploy Preview https://deploy-preview-4670--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

I searched for yarn and found a couple more places that also need to be updated, I'll update those tomorrow.

Additionally, the main workflow needs also need to include a release step.
When that's done we can close #4507 🚀

@timdeschryver timdeschryver merged commit 1b09685 into main Jan 15, 2025
10 checks passed
@timdeschryver timdeschryver deleted the pnpm-nx branch January 15, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants