Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): improve attendee and resource status display #6520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Nov 24, 2024

Resolves #4983

I refactored the logic and moved it to a computed prop to facilitate making use of the schedule status as well.

I also implemented some custom status messages if the scheduling fails for some reason (statuses 3.x and 5.x).

Screenshots

Organizer's view

Invitees Resources
image spectacle_20241124_205940

(In the example above, the user test was just added and the event was not saved yet. The same applies to the resource Croc.)

Attendee's view

image

@st3iny st3iny added 3. to review Waiting for reviews enhancement New feature request Feature: Editor Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on labels Nov 24, 2024
@st3iny st3iny self-assigned this Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 22.99%. Comparing base (1d63a89) to head (ec5076f).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rc/components/Editor/AvatarParticipationStatus.vue 0.00% 38 Missing ⚠️
src/components/Editor/Resources/ResourceList.vue 0.00% 3 Missing ⚠️
...rc/components/Editor/Invitees/InviteesListItem.vue 0.00% 2 Missing ⚠️
...c/components/Editor/Resources/ResourceListItem.vue 0.00% 2 Missing ⚠️
src/components/Editor/Invitees/InviteesList.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6520      +/-   ##
============================================
- Coverage     23.17%   22.99%   -0.19%     
- Complexity      472      475       +3     
============================================
  Files           250      252       +2     
  Lines         12020    12118      +98     
  Branches       2296     2310      +14     
============================================
  Hits           2786     2786              
- Misses         8907     9005      +98     
  Partials        327      327              
Flag Coverage Δ
javascript 14.52% <0.00%> (-0.14%) ⬇️
php 59.30% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny requested a review from GretaD December 17, 2024 09:59
@GretaD
Copy link
Contributor

GretaD commented Jan 6, 2025

the status icon is not aligned properly, it should be same everywhere. I remembered i fixed it here: #6580

@ChristophWurst
Copy link
Member

@GretaD try updating the branch locally. The last commit here appears to be older than the merge commit of your fix.

@st3iny st3iny force-pushed the feat/editor/attendee-status branch from 2f8a224 to ec5076f Compare January 10, 2025 10:20
@st3iny
Copy link
Member Author

st3iny commented Jan 10, 2025

the status icon is not aligned properly, it should be same everywhere. I remembered i fixed it here: #6580

Is fixed by a rebase. I tested it locally again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Editor Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show "Invitation sent" on shared calendars
3 participants