Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Ask ACCESS_MEDIA_LOCATION Permission If App Already Has Full Disk Access #14405

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 14, 2025

  • Tests written, or not not needed

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.30

@tobiasKaminsky tobiasKaminsky merged commit cb137eb into master Jan 14, 2025
16 of 19 checks passed
@tobiasKaminsky tobiasKaminsky deleted the dont-ask-ACCESS_MEDIA_LOCATION-permission-if-device-have-full-disk-access branch January 14, 2025 11:57
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14405.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total504504

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.30.8 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants