Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Add Tag Color #14339

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feature - Add Tag Color #14339

wants to merge 6 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 8, 2025 •
edited
Loading

  • Tests written, or not not needed
Image 1 Image 2 Image 2

@alperozturk96 alperozturk96 mentioned this pull request Jan 8, 2025
Open
2 tasks
@alperozturk96 alperozturk96 force-pushed the feature/add-tag-color branch 3 times, most recently from ee2fdb8 to c0eade3 Compare January 9, 2025 13:59
@tobiasKaminsky tobiasKaminsky mentioned this pull request Jan 14, 2025
Open
alperozturk96 and others added 5 commits January 14, 2025 10:35
@alperozturk96 @tobiasKaminsky
add system tag color
43c5aea 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @tobiasKaminsky
update library
ce0fc4b 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @tobiasKaminsky
revert
90710d9 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @tobiasKaminsky
add tag colors to the file details
ffe7dd4 
Signed-off-by: alperozturk <[email protected]>
@tobiasKaminsky
fix after rebase
c386471 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky
spotbugs
2c6ad93 
Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total504504

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14339.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @tobiasKaminsky