Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable signMessage for near-wallet #974

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented Oct 20, 2023

Description

This PR stops/disables the ability to trigger signMessage for NEAR Wallet since it's not supported.

This will avoid redirecting to a 404 page in the cases when users sign-in with NEAR Wallet and try the signMessage, since near-wallet in our side just wraps around the my-near-wallet setup it was enabled by default.

Closes: #973

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@kujtimprenkuSQA kujtimprenkuSQA force-pushed the 973-defect-sign-message-using-near-wallet-navigates-to-404-page branch from 06cc94d to 1d5b717 Compare October 20, 2023 07:56
@kujtimprenkuSQA kujtimprenkuSQA marked this pull request as ready for review October 20, 2023 07:58
@github-actions github-actions bot changed the title Disable signMessage for near-wallet, avoid redirecting to a 404 page. fix: Disable signMessage for near-wallet, avoid redirecting to a 404 page. Oct 20, 2023
@kujtimprenkuSQA kujtimprenkuSQA changed the title fix: Disable signMessage for near-wallet, avoid redirecting to a 404 page. Disable signMessage for near-wallet Oct 20, 2023
@github-actions github-actions bot changed the title Disable signMessage for near-wallet fix: Disable signMessage for near-wallet Oct 20, 2023
@kujtimprenkuSQA kujtimprenkuSQA self-assigned this Oct 20, 2023
@kujtimprenkuSQA kujtimprenkuSQA linked an issue Oct 20, 2023 that may be closed by this pull request
@kujtimprenkuSQA kujtimprenkuSQA merged commit c3dc0a5 into dev Oct 20, 2023
14 of 19 checks passed
@kujtimprenkuSQA kujtimprenkuSQA deleted the 973-defect-sign-message-using-near-wallet-navigates-to-404-page branch October 20, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Defect] Sign message using near-wallet navigates to 404 page
2 participants