feat: add support for meteor wallet mobile app #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trechriron
reviewed
Jan 9, 2025
- also added a ping in signIn that should resolve almost immediately to avoid auto login stuck
- this is so our app make sure we are processing the right message
gagdiez
reviewed
Jan 16, 2025
| @@ -0,0 +1,66 @@ | |||
| # @near-wallet-selector/meteor-wallet-app | |||
|
|
|||
| This is the [Meteor Wallet (for in app only)](https://meteorwallet.app) package for NEAR Wallet Selector. | |||
There was a problem hiding this comment.
I don't understand what it means for it to be in app only
Is this for a mobile app? or for a wallet embedded within apps?
If it is a mobile app, you could change it to:
This package is for the [Meteor Wallet **mobile app**](https://meteorwallet.app) package for NEAR Wallet Selector.
gagdiez
approved these changes
Jan 16, 2025
|
@trechriron looks good to me, I will ask one of the DevRels to test it in-depth next week so we can get a third pair of eyes |
|
We can release next week after some testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Meteor Wallet App integration. We mainly use this for in app browser, where user can browse the dapp within the meteor wallet. We are using
instant-linkwallet type to automatically sign in user for the dapp they are browsing.Checklist: