Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix directive naming Update check_nightly.py #12729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

annwag
Copy link
Contributor

@annwag annwag commented Jan 13, 2025

The comment above the EXPENSIVE_DIRECTIVE variable indicates that the script is supposed to look for tests annotated with expensive_tests, but the code currently uses ultra_slow_test_.

This mismatch could lead to unintended behavior. I've updated the variable to correctly reflect the intended directive:

EXPENSIVE_DIRECTIVE = 'expensive_tests'  

@annwag annwag requested a review from a team as a code owner January 13, 2025 17:20
@annwag annwag requested a review from akhi3030 January 13, 2025 17:20
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.66%. Comparing base (69ba684) to head (77ea270).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12729      +/-   ##
==========================================
- Coverage   70.66%   70.66%   -0.01%     
==========================================
  Files         848      848              
  Lines      173871   173871              
  Branches   173871   173871              
==========================================
- Hits       122874   122865       -9     
- Misses      45858    45865       +7     
- Partials     5139     5141       +2     
Flag Coverage Δ
backward-compatibility 0.16% <ø> (ø)
db-migration 0.16% <ø> (ø)
genesis-check 1.35% <ø> (ø)
linux 69.22% <ø> (-0.02%) ⬇️
linux-nightly 70.24% <ø> (-0.01%) ⬇️
pytests 1.65% <ø> (ø)
sanity-checks 1.46% <ø> (ø)
unittests 70.49% <ø> (-0.01%) ⬇️
upgradability 0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Longarithm
Copy link
Member

  1. the change is incorrect
  2. looks like the variable is not even used... @nagisa ?

@nagisa
Copy link
Collaborator

nagisa commented Jan 13, 2025

Ah yeah, that's my bad -- just remove that variable definition entirely since we aren't checking for #[...] anymore like we used to. Other than that ultra_slow_test_ is how we annotate our expensive tests that run in nayduck today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants