[code-infra] CircleCI maintenance #1321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michaldudak
commented
Jan 10, 2025
•
michaldudak
commented
- Removed the React 17 jobs (as in the Core repo). The shared test utils don't work with this version anymore.
- Corrected how TS is installed in the typescript@next pipeline
- Used more human-friendly names for all jobs for consistency
- Commented out the bundle-size-monitor job as it wasn't doing anything
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michaldudak
changed the title
LukasTy
reviewed
Jan 10, 2025
| - test_unit: | ||
| <<: *default-context | ||
| name: 'JSDOM tests' | ||
| requires: | ||
| - checkout | ||
| - Checkout |
There was a problem hiding this comment.
These should probably remain checkout as it relies on key, not the name. 🤔
The jobs seem stuck now. :/
Suggested change
| - Checkout | |
| - checkout |
There was a problem hiding this comment.
+1 to keep snake case to match with the rest of the codebase and with https://circleci.com/docs/introduction-to-yaml-configurations/ style.
Janpot
reviewed
Jan 10, 2025
| @@ -245,18 +233,13 @@ jobs: | |||
| - run: | |||
| name: Resolve typescript version | |||
| command: | | |||
| pnpm add typescript@next -d -w | |||
| pnpm install typescript@next -d -w | |||
There was a problem hiding this comment.
I think the best command I know for this is
pnpm update -r typescript@next
it should update every workspace in the repo where typescript is installed, including the root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.