llvm: update to 19.1.7 and add import libs fix for LLD #23136
Merged
+54
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. ok to merge despite it timing out? |
|
I had built each package in CLANG64 env before committing, so it should be fine, but if you want, I can just split it into two PRs. |
|
I think it's fine to just merge |
jeremyd2019
reviewed
Jan 19, 2025
Comment on lines
+118
to
+125
| apply_git_patch_with_msg() { | ||
| for _patch in "$@" | ||
| do | ||
| msg2 "Applying ${_patch}" | ||
| patch -Nbp1 -i "${srcdir}/${_patch}" | ||
| done | ||
| } | ||
|
|
There was a problem hiding this comment.
This function looks exactly like the apply_patch_with_msg function immediately above it. Is there some reason for another copy?
There was a problem hiding this comment.
Good point, this is a leftover.
At first I tried to apply the patch to a specific directory (lld/) but git patches require -p2 so I created this helper. Then I found out it's not going to work because the patch modifies llvm/ and lld/ at once. And here comes my mistake for modifying the new helper instead of using the previous one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21017