Soft Delete Sectors #236
Merged
Soft Delete Sectors #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a recent issue with retrieving deleted sector data that could have been prevented if sector objects were soft deleted. If a user accidentally deletes a sector, I'd be able to go back, look it up, and flip the deleted flag to false.
The downside of this is that users could have a lot of deleted sector data, but could easily be resolved by creating a cron-job that combs through deleted sectors and deletes them and all their children after a period of time. It's not terribly expensive to keep that data around, but could be a way to save some money in the future.