Add bind_address config field #2307
Conversation
|
Could you please document the change and add tests to make sure we don't regress? Thanks |
Use public_addr as default
sylvestre
force-pushed
the
work/bind_address
branch
from
959f35d to
c7aef2e
Compare
| @@ -0,0 +1,146 @@ | |||
| # Available Distributed Configuration Options | |||
There was a problem hiding this comment.
Shouldn't that be part of existing Distributed.md under a Configuration title? As a user that's where I'd first go look, having it split looks weird
There was a problem hiding this comment.
My rationale for creating a new file is having a canonical place to document configuration, as opposed to samples spread throughout Distributed.md and DistributedQuickstart.md.
Keeping the file separate also allows a quick reference for distributed configuration options and mirrors Configuration.md file structure.
I agree a Configuration section would also accomplish my first point. However, accessing the information would become a bit more unwieldy, and would bloat Distributed.md, which is already the largest doc.
Would a link in Distributed.md allay your concerns?
Allows binding to local address, uses
public_addras default.Fix for #930, #974.