Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more fix for the taskcluster build. #6556

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

bendk
Copy link
Contributor

@bendk bendk commented Jan 13, 2025

For some weird reason, the old command line was enabling the features for all binaries. Since the remote settings CLI depends on rc_crypto, this was causing failures when trying to build NSS. Adding the -p flag, fixes this.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

For some weird reason, the old command line was enabling the features
for all binaries.  Since the remote settings CLI depends on rc_crypto,
this was causing failures when trying to build NSS.  Adding the `-p`
flag, fixes this.
@bendk bendk requested a review from DonalMe January 13, 2025 18:44
@bendk
Copy link
Contributor Author

bendk commented Jan 13, 2025

🤞

@bendk bendk enabled auto-merge January 13, 2025 18:47
@bendk bendk added this pull request to the merge queue Jan 13, 2025
Merged via the queue into mozilla:main with commit 645d266 Jan 13, 2025
15 checks passed
@bendk bendk deleted the push-uopqpvlvspsu branch January 13, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants