Update gradle files to work in both app-services and mozilla-central #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
force-pushed
the
monorepo-wips
branch
from
a45c8b6 to
535d001
Compare
…of rootDir. The intent is that this will be the same as `rootDir` when in app-services, but magically turn into the root of the app-services tree once in mozilla-central.
mhammond
force-pushed
the
monorepo-wips
branch
from
535d001 to
24044d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of #6530
There are 3 commits here, mainly as some might be more controversial than others:
appServicesRootDirrather thanrootDir; no real functionality changes just a way so gradle works roughly the same in both places.Configobject as m-c. When app-services is in m-c, we end up using theConfigobject from m-c - the app-services version of this object is just for use in app-services so the same gradle code works in both places. Given some comments in the source it appears we maybe used to do that?gradle.hasProperty("mozconfig")if it needs to do something different based on the location. For now, that means things like disabling the cargo-gradle plugin and changing how uniffi-bindgen is run, etc. The implemented behaviour should be correct in app-services, but might be less so in m-c for now (eg, currently we just disable uniffi-bindgen, whereas ultimately we obviously still need to run it, once I work out how!)