Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MatchReason enum and associated uses #5901

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

skhamis
Copy link
Contributor

@skhamis skhamis commented Nov 2, 2023

fixes #5900

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (315850d) 36.54% compared to head (3b9f097) 36.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5901      +/-   ##
==========================================
+ Coverage   36.54%   36.57%   +0.03%     
==========================================
  Files         348      348              
  Lines       33723    33691      -32     
==========================================
  Hits        12324    12324              
+ Misses      21399    21367      -32     
Files Coverage Δ
components/places/src/api/matcher.rs 0.00% <ø> (ø)
components/places/src/ffi.rs 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skhamis skhamis requested review from a team and lougeniaC64 November 2, 2023 21:51
Copy link
Contributor

@lougeniaC64 lougeniaC64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moar code removal! DELETE ALL THE THINGS!!

@skhamis skhamis added this pull request to the merge queue Nov 3, 2023
Merged via the queue into mozilla:main with commit d587151 Nov 3, 2023
16 checks passed
@skhamis skhamis deleted the remove-matchreason branch November 3, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MatchResult from the API and sending across FFI
3 participants