Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old history delete methods #5894

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

skhamis
Copy link
Contributor

@skhamis skhamis commented Oct 31, 2023

fixes #4719

delete_everything is still actively used on android and iOS for a useful way to wipe to the DB and should be kept in.

android PR landed removed the wrappers (wasn't actually being used): mozilla-mobile/firefox-android@01bdb98

We should wait for the next nightly to merge this, but it can be reviewed!

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a3fbb8) 36.66% compared to head (e9aca44) 36.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5894      +/-   ##
==========================================
+ Coverage   36.66%   36.68%   +0.01%     
==========================================
  Files         348      348              
  Lines       33677    33663      -14     
==========================================
  Hits        12349    12349              
+ Misses      21328    21314      -14     
Files Coverage Δ
components/places/src/ffi.rs 0.00% <ø> (ø)
components/places/src/storage/history.rs 0.00% <ø> (ø)
components/places/src/storage/history_metadata.rs 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skhamis skhamis changed the title Remove old history delete methods Remove old history delete methods [firefox-android: main] Oct 31, 2023
@skhamis skhamis force-pushed the remove-old-wipe-methods branch 2 times, most recently from fbf0aac to 684fcd0 Compare October 31, 2023 01:53
@skhamis skhamis changed the title Remove old history delete methods [firefox-android: main] Remove old history delete methods [firefox-android: skhamis/remove-old-wipe-methods] Nov 1, 2023
@skhamis skhamis force-pushed the remove-old-wipe-methods branch from 684fcd0 to 9464e07 Compare November 1, 2023 19:10
@skhamis skhamis changed the title Remove old history delete methods [firefox-android: skhamis/remove-old-wipe-methods] Remove old history delete methods Nov 2, 2023
@skhamis skhamis requested review from a team and lougeniaC64 November 2, 2023 21:52
@@ -2641,7 +2626,7 @@ mod tests {

assert!(bookmarks::delete_bookmark(&conn, &b0.0).unwrap());

wipe_local(&conn).unwrap();
delete_everything(&conn).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Might be worthwhile to update the test name.

Copy link
Contributor

@lougeniaC64 lougeniaC64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skhamis skhamis changed the title Remove old history delete methods Remove old history delete methods [firefox-android: main] Nov 3, 2023
@skhamis skhamis force-pushed the remove-old-wipe-methods branch from 9464e07 to 7be4928 Compare November 3, 2023 18:46
@skhamis skhamis closed this Nov 3, 2023
@skhamis skhamis reopened this Nov 3, 2023
@skhamis skhamis force-pushed the remove-old-wipe-methods branch from 7be4928 to e9aca44 Compare November 6, 2023 20:22
@skhamis skhamis added this pull request to the merge queue Nov 6, 2023
@skhamis skhamis changed the title Remove old history delete methods [firefox-android: main] Remove old history delete methods Nov 6, 2023
Merged via the queue into mozilla:main with commit 8aa85ff Nov 6, 2023
17 checks passed
@skhamis skhamis deleted the remove-old-wipe-methods branch November 6, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and remove unused Sync APIs and related implementations
3 participants