-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old history delete methods #5894
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5894 +/- ##
==========================================
+ Coverage 36.66% 36.68% +0.01%
==========================================
Files 348 348
Lines 33677 33663 -14
==========================================
Hits 12349 12349
+ Misses 21328 21314 -14
☔ View full report in Codecov by Sentry. |
fbf0aac
to
684fcd0
Compare
684fcd0
to
9464e07
Compare
@@ -2641,7 +2626,7 @@ mod tests { | |||
|
|||
assert!(bookmarks::delete_bookmark(&conn, &b0.0).unwrap()); | |||
|
|||
wipe_local(&conn).unwrap(); | |||
delete_everything(&conn).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Might be worthwhile to update the test name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9464e07
to
7be4928
Compare
7be4928
to
e9aca44
Compare
fixes #4719
delete_everything
is still actively used on android and iOS for a useful way to wipe to the DB and should be kept in.android PR landed removed the wrappers (wasn't actually being used): mozilla-mobile/firefox-android@01bdb98
We should wait for the next nightly to merge this, but it can be reviewed!
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.