Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-10139 [Menu] ⁃ Investigate Save as PDF option for Save Sub Menu #24150

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dicarobinho
Copy link
Collaborator

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

Added a new option under the Save submenu (Print as PDF)

πŸ“ Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho dicarobinho marked this pull request as ready for review January 15, 2025 12:16
@dicarobinho dicarobinho requested a review from a team as a code owner January 15, 2025 12:16
@mobiletest-ci-bot
Copy link

Messages
πŸ“– Project coverage: 33.32%
πŸ“– Edited 8 files
πŸ“– Created 1 files

Client.app: Coverage: 32.38

File Coverage
MainMenuMiddleware.swift 38.82% ⚠️
BrowserCoordinator.swift 70.77% βœ…
MenuNavigationDestination.swift 100.0% βœ…
MainMenuCoordinator.swift 87.58% βœ…
PDFDocument+Extension.swift 0.0% ⚠️
MainMenuConfigurationUtility.swift 26.45% ⚠️
BookmarksSaver.swift 98.07% βœ…

Generated by 🚫 Danger Swift against cb0bed3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants