Revert "blockchain: detect and log bad difficulty calculations" #9688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5741b4d.
selsta
force-pushed
the
revert-diff-log
branch
from
b048d3a to
26b4f5e
Compare
tobtoht
approved these changes
Jan 14, 2025
0xFFFC0000
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5741b4d.
This change got introduced in #6544 with the goal to find a race condition in the difficulty code, it was found and fixed in #6650. Since then no issues have been found and 5 years have passed, it is time to revert it since it slows down the code.
Even after reverting this patch we still have a safeguard against race conditions with #6534.