-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add strict validation against Hydra's supported primitives (#163)
* add initial framework for zen value conversion * Validate that all configured values satisfy Hydra serializability * bugfix: ref to wrong variable * cleanup test boilerplate * fix bug * add support for set; normalize builds-error * add validation/conversion to contents of supported collections: tuple,list,dict * Validation now requires exact match against types -- subclasses no longer permitted * add tests for zen-supported primitives * add support for complex values * add support for Path objects * remove extra complex implementation * update type-annotations to reflect supported primitives * add frozenset support * improve test * relax health checks * eliminate redundant dict copy * ensure zen-converted values are supported by Hydra * Add support for enum members * add explicit tests for supported primitives * add support for additional primitives * remove straggler line * clean up import * make test compatible with python 3.6 * remove unused imports * dataclasses are not permitted for dict-key nodes * inline just-if-needed; dont permit structured configs as keys * add support for omegaconf containers * ensure omegaconf containers not permitted as dict keys * remove unused function * add annotation support for range; remove redundant annotations * remove future import * remove unused import * add docs for features * wrap long line * test that meta fields are validated too * remove commented print * fix bad test
- Loading branch information
Showing
14 changed files
with
938 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.