Implement fast track deletion for unused wikis #605
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
maintenance/manageInactiveWikis.php
Outdated
| @@ -51,7 +51,7 @@ public function execute(): void { | |||
| foreach ( $res as $row ) { | |||
| $dbName = $row->wiki_dbname; | |||
| $remoteWiki = $remoteWikiFactory->newInstance( $dbName ); | |||
| $inactiveDays = (int)$this->getConfig()->get( ConfigNames::StateDays )['inactive']; | |||
| $inactiveDays = (int)$this->getConfig()->get( ConfigNames::StateDays )['default']['inactive']; | |||
There was a problem hiding this comment.
I wonder if this should be no-edits?
There was a problem hiding this comment.
I think so? I'll do some thinking, but also need to look to make sure we're not breaking any previously implemented assumptions about the state from when there was only one track.
There was a problem hiding this comment.
If the no_edits_inactivity < default_inactivity, but we only do checking for when it's default, then the no edits stuff won't trigger, right?
There was a problem hiding this comment.
Updated to no-edits, but we should take a look to see if that doesn't break and assumptions and cause it to early close any wikis it shouldn't. A bit late for me to be doing a thoughtful look right now though.
|
Looks ~~gay~~ good to me
|
This was requested and approved by the community in https://meta.miraheze.org/wiki/Requests_for_Comment/Content_and_Dormancy_Policies back in March(over half a year ago, so long overdue and then some).
Since many, many, many wiki requests unfortunately never really get into editing and just give up on or forget about making entirely, leaving swarms of ghost wikis on the site taking up space.
This pull request implements the 'fast-track' deletion, where wikis that have no edits(besides MediaWiki default) are marked as inactive after 15 day, and deleted after 30.
Rest in peace our 10k badge.