add . and ../ completions

[meganrogge]

fixes #234351

[Tyriar]

Testing this out now. The ../ here should re-trigger the completions on Windows only, just as ..\ does. Right now it just continues the filter the items:

EDIT: Just closing the widget and triggering again shows this:

So I think we need to handle / on Windows too when resolving the resources.

[Tyriar]

I'm not seeing . show up on Windows. This is what I see:

Bottom of the list:

[Tyriar]

When you complete cd ..\ I see this:

Notice the odd filtering of the very last item ..\. It should show up first in the list and be fully blue? This would make it work really well with "terminal.integrated.suggest.runOnEnter": "exactMatchIgnoreExtension" and exactMatch.

[meganrogge]

When you complete cd ..\ I see this:

Notice the odd filtering of the very last item ..\. It should show up first in the list and be fully blue? This would make it work really well with "terminal.integrated.suggest.runOnEnter": "exactMatchIgnoreExtension" and exactMatch.

that's because looks like it has the wrong replacement index?

[Tyriar]

Some test cases to work through when we meet:

Test cases:

• Windows
  • .| should show . (top) and ..\
  • ..\| should show ..\ (top) and ..\..\
  • ../| should show ..\ (top) and ..\..\
  • ..\ should show directories of ..\ (top)
  • ../..\ should show ..\..\ (top) and ..\..\..\
• Mac
  • When directories are completed, the completed dir should always show at the top result (eg. ., .., ../, ../../, ./src/, ../xterm.js, etc.)
• Both
  • Resolve actual folder name as detail for ., ..\, ~, etc.
  • Filtering on front end
    • Triggering at ./sr| should show the exact same results as when it's triggered at ./ and sr is typed
    • Triggering at ./src/cm| should find ./src/common
  • Without ./
    • Any ./ query should show exactly the same results as without the ./. Eg. ./src/| should be the same as src/|
    • cd c| should show src/ (or ./src/ as result)
  • Folders should be resolved even if the trailing / is missing
    • ./src should show ./src/ (top) and ./src/<other_dirs>
  • cd ./src/.. should not show multiple entries for cd ./src/../

Discussion:

• ../ Scoring

  • Since this is easy to type and probably a low chance of being completed, should this go to the bottom unless it's an exact match?
    • eg. ./src/ shows ./src/ then ./src/../, taking up valuable real estate

• Define behavior for when ../ shows up exactly

  • Should we show when another folder is typed?
    • Eg. ./src/ showing ./src/..?
      • If so, should that completion be smarter and "complete" to ./?
    • Should we just not show <prefix>../ unless it matches /(\.\.\/)+/?

[Tyriar]

We need to handle the Windows primary paths in the test:

addressed